search

misode / upgrader

https://misode.github.io/upgrader/
MIT License
20 stars 2 forks source link

Worldgen Upgrade changes how the datapack generates the world #16

Closed DemiWrath closed 2 years ago

DemiWrath commented 2 years ago

cal45_null_do_not_distribute_1.18.2.zip cal45_null_do_not_distribute.zip

These two generate differently, the 1.18.2 version has no gaps inbetween the islands and no visible void

misode commented 2 years ago

Okay I can confirm the difference. This is an issue with how I implemented the noise router upgrading, I have to investigate this.

1.18.1 1.18.2
image image

Noise settings diff

misode commented 2 years ago

Okay this was tricky to find. The problem is that the vanilla overworld/depth density function clamps the output of the terrain shaper spline. The offset spline has values as low as -4 in noise settings, while the depth is clamped between -0.81 and 2.5.

The workaround right now is to overwrite that depth density function with correct min_value and max_value values. This may also need to be done for the other two terrain shaper fields.

In theory this could be verified and corrected for by the upgrader, but I'm not sure if that's worth it so don't wait for it.