This registry can't create new holders without value

misode / upgrader

https://misode.github.io/upgrader/

MIT License

20 stars 2 forks source link

This registry can't create new holders without value #18

Open misode opened 2 years ago

misode commented 2 years ago

Reported by WilliamWythers. 1.18.1 -> 1.18.2. The working upgraded version does not validate in 1.18.2.

1.18.1 download

Failed to validate datapack java.util.concurrent.CompletionException: java.lang.IllegalStateException: This registry can't create new holders without value

catter1 commented 1 year ago

Hey, was a fix found for this, or even a general idea on what to check for? I'm now getting this error when trying to downgrade a pack from 1.19 to 1.18.2.

From looking at half-a-year old messages, Apollo mentioned it worked when switching between Fabric/Vanilla, Cyanide/no Cyanide, and it randomly started working again. I've tried messing with that, but no luck.

And I also found the messages from the original issue in MC Configs discord, but I didn't see it ever get resolved.

misode commented 1 year ago

No it was never resolved. I don't even know what area the problem could be in.

catter1 commented 1 year ago

After further testing, I discovered that the error ocurred when there was sculk block reference in the 1.18.2 worldgen - specifically, one of the placed features. After replacing it with blackstone, that error went away.

misode commented 1 year ago

It seems unlike that was the root cause of this issue. In the attached pack above there is no mention of sculk blocks anywhere. Could you maybe provide both broken and working versions of your 1.18.2 pack?

catter1 commented 1 year ago

The file where sculk was referenced was data/nullscape/worldgen/placed_feature/infested/tendril.json. I am attaching 3 datapacks.

The first datapack with_sculk.zip is at the beginning of my backport, and has sculk references in there. This is where I got the "this registry cannot create new holders" error.
The second datapack without_sculk.zip is after I replaced all sculk with blackstone. It no longer has that registry holder error, but still has other unrelated worldgen errors, since I hadn't finished backporting the other worldgen stuff.
The third datapack without_sculk_no_errors.zip is after I finished backporting everything, so it loads correctly with no errors.

I haven't gone back and tested the first datapack after I finished backporting everything, so I'm curious if it happens again.