misogi / vscode-ruby-rubocop

Rubocop extension for Visual Studio Code
https://marketplace.visualstudio.com/items/misogi.ruby-rubocop
MIT License
137 stars 68 forks source link

Cops with Info-level severity should display as info-level #154

Closed anateus closed 2 years ago

anateus commented 3 years ago

What

Added a case that renders cops with info level severity as DiagnosticSeverity.Information.

Why

Currently, cops that are set to return info-level severity are rendered as warnings, with a red underline and a red warning icon. Per the Rubocop documentation info is the lowest level, ranking even below refactor so it should definitely not be displayed as something more severe. Because of its name matching the name and the icon of the Information diagnostic severity I chose to use that one instead of using the lower level Hint one and grouping it with refactor.

misogi commented 2 years ago

Thank you for your contribution.