misogi / vscode-ruby-rubocop

Rubocop extension for Visual Studio Code
https://marketplace.visualstudio.com/items/misogi.ruby-rubocop
MIT License
137 stars 68 forks source link

unchecking 'execute robocop on save' setting does not prevent robocop from being executed on save #180

Open rodeezy opened 1 year ago

suryanarayanan-rently commented 6 months ago

Hey @rodeezy , could you please provide your workspace settings?

kapso commented 3 months ago

I am also seeing this issue, after today's VSCode update

https://github.com/microsoft/vscode/issues/221489

chinghanho commented 3 months ago

I think I have found a possible reason: https://github.com/Shopify/ruby-lsp/commit/176254330d27c515b0921d2d26772360f71a9aaf

Disabling the Ruby LSP extension may help.

Or you can turn the configuration formatOnSave off in user settings (JSON):

"[ruby]": {
    "editor.formatOnSave": false
}
rodeezy commented 3 months ago

im pretty sure i had ruby-lsp installed! sounds like could be it! @chinghanho 💡