search

misogi / vscode-ruby-rubocop

Rubocop extension for Visual Studio Code
https://marketplace.visualstudio.com/items/misogi.ruby-rubocop
MIT License
137 stars 68 forks source link

Upgrade version of typescript to match that used by current version of VSCode #35

Closed damien closed 7 years ago

damien commented 7 years ago

Context

I received the following warning while working on this repository:

vscode-ruby-rubocop 2017-02-14 13-32-17

The latest version of VSCode uses typescript@2.1.6, while this repository uses typescript@2.0.7, resulting in a mismatch of the version of tsc used to compile/evaluate this extension.

Upgrading typescript to version 2.1.6 fixes this problem.

damien commented 7 years ago

@misogi Let me know what you think!

I plan on having a number of PRs for you, I'll do my best to keep each one small and easy to review!

misogi commented 7 years ago

Good!

I choose typescript version by references to vscode tutorial. https://code.visualstudio.com/docs/extensions/example-hello-world

But I want to use latest version of typescript too.