misogi / vscode-ruby-rubocop

Rubocop extension for Visual Studio Code
https://marketplace.visualstudio.com/items/misogi.ruby-rubocop
MIT License
137 stars 68 forks source link

Fix autoCorrection find on windows #81

Closed TikiTDO closed 6 years ago

TikiTDO commented 6 years ago

Current implementation for extracting the corrected result from the output fails on windows due to line ending types.

JoeMcB commented 6 years ago

I literally just spent all morning learning how to debug VS Code extensions to fix this. Beat me to it by 3 months! 👍

For what it's worth, the updated regex also works as stringOut.match(/^{.*}====================\r?\n([.\s\S]*)/m).

Can this get merged, @misogi ?

misogi commented 6 years ago

@TikiTDO Thanks for your contribution. 👍 Sorry for late.

I will merge and release new version.

misogi commented 6 years ago

Updated.

Please update an extension on your environment.

https://marketplace.visualstudio.com/items?itemName=misogi.ruby-rubocop#overview