misoproject / dataset

JavaScript library that makes managing the data behind client-side visualisations easy
http://misoproject.com
GNU General Public License v2.0
1.18k stars 99 forks source link

require.js with miso dataset 0.2.1 #166

Closed pwistrand closed 12 years ago

pwistrand commented 12 years ago

I'm trying to get miso dataset working with require.js. has anyone successfully done this? I've having difficulty as while Miso is defined Miso.Dataset is not.

require.config({ paths: { jquery: 'lib/jquery', knockout: 'lib/knockout', domReady: 'lib/domReady',
misoDataset: 'lib/miso.ds.deps.min.0.2.1' } });

require(['knockout', 'jquery', 'misoDataset', 'appViewModel', 'customHandlers', 'domReady!'], function(ko, $, Miso, appViewModel) {

var ds = new Miso.Dataset({
iros commented 12 years ago

We'll add require support in the next version. Thanks for reporting the issue.

iros commented 12 years ago

Fixed in pull req above