misoproject / dataset

JavaScript library that makes managing the data behind client-side visualisations easy
http://misoproject.com
GNU General Public License v2.0
1.18k stars 99 forks source link

Bug? : Column-filtered subselection of a syncable dataset : Unable to add rows to the dataset #207

Open chanakyabhardwajj opened 11 years ago

chanakyabhardwajj commented 11 years ago

I have attached a simple code below, that reproduces the error :

//Create a syncable dataset
var ds = new Miso.Dataset({
  data: [{ one : 1, two : 2, three : 3 }], 
  sync:true
});

ds.fetch({ 
  success: function() {

    //Create a subselection using where
    var oneTwo = this.where({
      columns: ['three'],
      rows: function(row) {
        return row.one == 1;
      }
    });

    //This runs fine
    console.log(oneTwo.length);

    //This one fails to add the row
    ds.add({ one : 1, two : 4, three : 5 });

    console.log(oneTwo.length);
  }
});
iros commented 10 years ago

As noted in pull req comment, can you separate out the fix for this issue from the reversing of the rows-to-remove? I will merge it then. Thanks!