search

misoproject / dataset

JavaScript library that makes managing the data behind client-side visualisations easy
http://misoproject.com
GNU General Public License v2.0
1.18k stars 99 forks source link

revmoving multiples rows with function was failing, when detected indice... #210

Open alexmasselot opened 11 years ago

alexmasselot commented 11 years ago

Indices of lines to be removed are stored increasingly.

reversing the list of index solved it

iros commented 11 years ago

Can we separate teh #207 issue from the reversing of rows? I agree that both are issues but I don't want to bundle them in the same pull request. I reviewed the fix for #207 and that looks good. Not sure about the reversing quite yet.

alexmasselot commented 11 years ago

Sure! I'm not used to github and somehow it merged the two pull request. On Oct 1, 2013 3:07 PM, "Irene Ros" notifications@github.com wrote:

Can we separate teh #207 issue from the reversing of rows? I agree that both are issues but I don't want to bundle them in the same pull request. I reviewed the fix for #207 and that looks good. Not sure about the reversing quite yet.

— Reply to this email directly or view it on GitHub.

alexmasselot commented 11 years ago

All this makes sense. Changed made and pushed

jalada commented 10 years ago

It seems really unnecessary to reverse the entire array for iterating. Why not just unshift instead of push so that the array is the right way round?

alexmasselot commented 10 years ago

Hi David,

Thanks for your email

By now way I claim that to be the best solution. I was stucked there and found the simplest way around. In the other hand, I put a few unit test there for that matter, so try any solution that fit them. Isn't that the goal:)

happy coding Alex

On Mon, Jul 14, 2014 at 6:52 AM, David Somers notifications@github.com wrote:

It seems really unnecessary to reverse the entire array for iterating. Why not just unshift instead of push so that the array is the right way round?

— Reply to this email directly or view it on GitHub https://github.com/misoproject/dataset/pull/210#issuecomment-48901784.

Alexandre Masselot

http://alexandre-masselot.blogspot.com/ http://mtroopgoeswest.blogspot.com/

jalada commented 10 years ago

Indeed, I submitted another pull request (#223) Alex :)

alexmasselot commented 10 years ago

super cool! Alex

On Wed, Jul 16, 2014 at 6:22 AM, David Somers notifications@github.com wrote:

Indeed, I submitted another pull request (#223 https://github.com/misoproject/dataset/pull/223) Alex :)

— Reply to this email directly or view it on GitHub https://github.com/misoproject/dataset/pull/210#issuecomment-49163998.

Alexandre Masselot

http://alexandre-masselot.blogspot.com/ http://mtroopgoeswest.blogspot.com/