misoproject / dataset

JavaScript library that makes managing the data behind client-side visualisations easy
http://misoproject.com
GNU General Public License v2.0
1.18k stars 99 forks source link

Fix for incorrect row removal with function #223

Closed jalada closed 3 years ago

jalada commented 10 years ago

When more than one row was removed, sometimes the wrong row would be removed due to the direction of removal (first to last rather than last to first).

This is related to #210, but that solution involved reversing the array of rows to remove, which doesn't seem very performant. This solution unshifts the row indices so they're in the right order to begin with. I wrote a similar corresponding test which fails without this fix.

jalada commented 3 years ago

👋🏻 from 2021!