search

missinglink / pbf

utilities for parsing OpenStreetMap PBF files and extracting geographic data
MIT License
21 stars 9 forks source link

add more highway tag values to determine streets #19

Closed tadjik1 closed 1 week ago

tadjik1 commented 5 years ago

This should solve #18

missinglink commented 5 years ago

Heya, could you please give a brief description of the new tags and why they are included, so we have it in the GitHub history?

tadjik1 commented 5 years ago

I can add this directly to file as comment, would it be better?

missinglink commented 5 years ago

That would be good, I'm just wondering because that tag whitelist is shared with another 'handler' so I'm not sure if it would be best to update that one or make a new one.

tadjik1 commented 5 years ago

ok,

  1. highway=pedestrian "For roads used mainly/exclusively for pedestrians in shopping and some residential areas which may allow access by motorised vehicles only for very limited periods of the day." Example: https://www.openstreetmap.org/way/32108473

  2. highway=living_street "For living streets, which are residential streets where pedestrians have legal priority over cars, speeds are kept very low and where children are allowed to play on the street." Example: https://www.openstreetmap.org/way/114189255

  3. highway=unclassified this one should not be used in OSM, since it's an artifact for UK roads but for some reasons there are still streets with this tag, for example: https://www.openstreetmap.org/way/24040277

missinglink commented 5 years ago

Heya, I was just about to merge this, should we hold off a bit longer to see if there are additional tags to add?

tadjik1 commented 5 years ago

yep, good idea. I'm currently doing some tests against other datasource that provides addresses and I found couple of more potential things:

  1. highway=track. this value should not be used for streets, howerer from time to time people are using it. example: https://www.openstreetmap.org/way/25528903

Also some squares could potentially have houses on it. Should it be considered as streets or not? So basically the question here is: should we import squares from OSM importer or from Polyline importer? Example: https://www.openstreetmap.org/node/6167275128 weird thing about squares - they could be nodes, ways and relations.

missinglink commented 5 years ago

Hi @tadjik1 what's the status of this? I saw you closed the PR. Was there nothing here that could be used by others?

arnesetzer commented 1 year ago

Any news here? At least in our project, we need the polylines with the mentioned tags included. So it would be a relief not to copy/recompile the new binary on every new machine.

missinglink commented 1 year ago

@arnesetzer can you take over this PR? It's out of date and needs a review of the tags.

missinglink commented 1 week ago

resolved via https://github.com/missinglink/pbf/pull/36