search

missinglinkelectronics / sphinxcontrib-svg2pdfconverter

Sphinx SVG to PDF converter extension
Other
21 stars 10 forks source link

Sphinx < 1.8 not supported #2

Closed mgeier closed 5 years ago

mgeier commented 5 years ago

setup.py claims to support Sphinx 1.6:

https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter/blob/b57700a1efdf30b894ef38965ae91dba99ef8736/setup.py#L10

But this is used:

https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter/blob/b57700a1efdf30b894ef38965ae91dba99ef8736/sphinxcontrib/rsvgconverter.py#L16

Which was introduced in Sphinx 1.8: https://github.com/sphinx-doc/sphinx/pull/4674

sephalon commented 5 years ago

Sphinx 1.6 is actually supported, but starting only from 1.6.3, when a dummy wrapper for __() was introduced. I will fix the version requirement.

mgeier commented 5 years ago

Thanks for the info. I've removed my own dummy wrapper and updated my own requirements to Sphinx 1.6.3 (https://github.com/spatialaudio/nbsphinx/pull/322) and now my tests pass!

sephalon commented 5 years ago

Release v1.0.1 including this fix is now out; so you might want to update your dependencies.