mission-apprentissage / cerfa

Générateur de contrat publique en apprentissage
https://contrat.apprentissage.beta.gouv.fr
MIT License
4 stars 0 forks source link

refactor: sonar shadowed variables #833

Closed flodlc closed 1 year ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #833 (e67b6ff) into develop (46890b9) will decrease coverage by 0.78%. The diff coverage is 30.27%.

@@             Coverage Diff             @@
##           develop     #833      +/-   ##
===========================================
- Coverage    42.76%   41.98%   -0.79%     
===========================================
  Files          110      112       +2     
  Lines         3056     3111      +55     
===========================================
- Hits          1307     1306       -1     
- Misses        1749     1805      +56     
Impacted Files Coverage Δ
server/src/common/apis/ApiAgecap.js 20.33% <0.00%> (-14.15%) :arrow_down:
server/src/common/apis/yousign/ApiYousign.js 21.62% <0.00%> (-0.61%) :arrow_down:
server/src/common/components/cerfas.js 22.95% <0.00%> (-1.19%) :arrow_down:
server/src/common/model/schema/log.js 100.00% <ø> (ø)
...rc/common/model/schema/specific/dossier/Dossier.js 100.00% <ø> (ø)
...ommon/model/schema/specific/dossier/cerfa/Cerfa.js 100.00% <ø> (ø)
...chema/specific/dossier/cerfa/parts/adresse.part.js 87.50% <ø> (ø)
...chema/specific/dossier/cerfa/parts/contrat.part.js 95.00% <ø> (-0.24%) :arrow_down:
...chema/specific/dossier/cerfa/parts/diplome.part.js 100.00% <ø> (ø)
...dossier/cerfa/parts/etablissementFormation.part.js 69.23% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f671f0c...e67b6ff. Read the comment docs.

antoinebigard commented 1 year ago

:tada: This PR is included in version 2.12.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

antoinebigard commented 1 year ago

:tada: This PR is included in version 2.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: