missioncommand / mil-sym-java

(RETIRED) MIL-STD-2525 B and C rendering library and web service
Apache License 2.0
67 stars 36 forks source link

Circular Range Fan labels are incorrect #31

Closed y2kbowen closed 7 years ago

y2kbowen commented 7 years ago

A circular range fan is defined to have labels MIN RG for AM MAX RG (1) for AM1 and MAX RG (2) for AM2. For example: if AM set to 50000 then is should be displayed and MIN RG 50000 if AM1 set to 150000 then is should be displayed as MAX RG (1) 150000 if AM2 set to 250000 then it should be displayed as MAX RG (2) 250000

What is rendered is RG 50000 RG1 150000 RG2 250000

Picture of what is shown is attached. Also a fiddler capture of the call is attached.

circularlabelerror circularlabelerrorfiddlercapture

mdeutch3 commented 7 years ago

Did you set the altitudeDepth (X) array? I don't see it in the modifiers.

michael-spinelli commented 7 years ago

He's not talking about altitude. He's saying our labels for AM are wrong.

mdeutch3 commented 7 years ago

Our design intent was to keep the text to a minimum for range fan ranges and they followed the example that was shown for sector range fans, only using RG for the labels. Also if the HIDEOPTIONALLABELS modifier is set then it omits the ranges.

michael-spinelli commented 7 years ago

If sector uses RG, and that's what the milstd says, that's fine. But we should probably fix Circular Range Fan.

mdeutch3 commented 7 years ago

The range labels have been modified, the change has been checked in.

michael-spinelli commented 7 years ago

A new release will come out next week.

michael-spinelli commented 7 years ago

fixed in release v0.1.16

y2kbowen commented 7 years ago

The update labels are not correct in build v0.1.16. Picture attached.

if AM set to 100000 then is should be displayed and MIN RG 100000 (This is rendering correctly) if AM1 set to 400000 then is should be displayed as MAX RG (1) 400000 (This is showing MIN RG (1)) if AM2 set to 800000 then it should be displayed as MAX RG (2) 800000 (this is showing MIN RG (2))

circular range fan bad labels

mdeutch3 commented 7 years ago

The labels have been changed to display MAX RG.

michael-spinelli commented 7 years ago

fixed in release 0.1.17