search

missioncommand / mil-sym-java

(RETIRED) MIL-STD-2525 B and C rendering library and web service
Apache License 2.0
67 stars 36 forks source link

getMilStdSymbolasIcon Returning Incorrectly Colored Icon #36

Closed david-melendez closed 7 years ago

david-melendez commented 7 years ago

Attempting to retrieve an icon for the following graphics returns an icon that has the wrong color for the fill of the icon. Some of the icons has no fill color when they should and some have a slightly different color that the properly rendered graphic.

|METOC|OCEANIC|OCEANOGRAPHY|BIOLUMINESCENCE|VRD LEVEL 1-2
|METOC|OCEANIC|OCEANOGRAPHY|BIOLUMINESCENCE|VRD LEVEL 2-3
|METOC|OCEANIC|GEOPHYSICS/ACOUSTICS|MINE WARFARE BOTTOM DESCRIPTORS|MIW BOTTOM TYPE|C2
|METOC|OCEANIC|GEOPHYSICS/ACOUSTICS|MINE WARFARE BOTTOM DESCRIPTORS|MIW BOTTOM TYPE|C3
|METOC|OCEANIC|MAN-MADE STRUCTURES|SUBMERGED CRIB
|METOC|OCEANIC|HYDROGRAPHY|COASTAL HYDROGRAPHY|ISLAND
|METOC|OCEANIC|HYDROGRAPHY|COASTAL HYDROGRAPHY|BEACH
|METOC|OCEANIC|HYDROGRAPHY|COASTAL HYDROGRAPHY|FORESHORE|FORESHORE LINE
|METOC|OCEANIC|HYDROGRAPHY|PORTS AND HARBORS|FACILITIES|DRYDOCK
|METOC|OCEANIC|HYDROGRAPHY|PORTS AND HARBORS|FACILITIES|OFFSHORE LOADING FACILITY (AREA)
|METOC|OCEANIC|HYDROGRAPHY|AIDS TO NAVIGATION|PERCHES/STAKES|PERCHES/STAKES (AREA)
|METOC|OCEANIC|HYDROGRAPHY|DANGERS/HAZARDS|UNDERWATER DANGER/HAZARD
|METOC|OCEANIC|HYDROGRAPHY|DANGERS/HAZARDS|DISCOLORED WATER
|METOC|OCEANIC|OCEANOGRAPHY|BEACH SLOPE|STEEP
|METOC|OCEANIC|GEOPHYSICS/ACOUSTICS|MINE WARFARE BOTTOM DESCRIPTORS|MIW-BOTTOM SEDIMENTS|SOLID ROCK
michael-spinelli commented 7 years ago

Deutch, you're going to have to run through and check METOC area fill colors. They're not matching 2525.

Island (WO-DHCI-----A--) for example, is pretty far off. Drydock (WO-DHPMD----A--) is another.

I believe I fixed all the colors for the icon variants of these symbols.

mdeutch3 commented 7 years ago

Fixed METOC fill colors have been checked in.

michael-spinelli commented 7 years ago

fixed in release v0.1.16

david-melendez commented 7 years ago

Based on v0.1.16, this issue is partially fixed. The following symbol icon colors appear to be correct:

The following have inconsistent information in the standard. Each of these symbols have a blue fill according to the standard, but the color in the displayed graphic (as seen in the document standard) for Submerged Crib is blue, but is cyan for Underwater Danger/Hazard and Discolored Water. All the icons are blue (RGB = 0000FF) in color, but the rendered KML color is 00BFFF for Underwater Danger/Hazard and Discolored Water.

The following are incorrect:

michael-spinelli commented 7 years ago

Checked in an update. For Underwater Danger/Hazard and Discolored Water I made them Cyan to match the example since no specific RGB values were called out in the 2525 for those symbols.

mdeutch3 commented 7 years ago

Of the 3 multi-point symbols that were listed, the standard says blue. Does the standard say they are RGB 0000FF? We are going by what they display. For example we have symbols where it says brown but displays different colors. Where they do specify an RGB color we use the RGB value specified.

david-melendez commented 7 years ago

I am not sure if there is a specific place that specifies what RGB values are to be used for what METOC symbols. I just noted that all three symbols say blue fill in the standard, but two of the symbols are rendered in Cyan.

I received the following email from Michael Spinelli regarding his actions for this issue:

Checked in an update. For Underwater Danger/Hazard and Discolored Water I made them Cyan to match the example since no specific RGB values were called out in the 2525 for those symbols.

David Melendez

mailto:david.melendez@nova-tech-solutions.com david.melendez@nova-tech-solutions.com

Software Engineer

Nova Tech Solutions

From: mdeutch3 [mailto:notifications@github.com] Sent: Tuesday, January 3, 2017 3:27 PM To: missioncommand/mil-sym-java mil-sym-java@noreply.github.com Cc: david-melendez david.melendez@nova-tech-solutions.com; Author author@noreply.github.com Subject: Re: [missioncommand/mil-sym-java] getMilStdSymbolasIcon Returning Incorrectly Colored Icon (#36)

Of the 3 multi-point symbols that were listed, the standard says blue. Does the standard say they are RGB 0000FF? We are going by what they display. For example we have symbols where it says brown but displays different colors. Where they do specify an RGB color we use the RGB value specified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/missioncommand/mil-sym-java/issues/36#issuecomment-270229421 , or mute the thread https://github.com/notifications/unsubscribe-auth/AVkzUyawQMAFuz4HkA6jF04dUxsh1hqTks5rOr0jgaJpZM4LPkV5 . https://github.com/notifications/beacon/AVkzU4NbGlTVv1UdzHJ0mhESwOWxOdRGks5rOr0jgaJpZM4LPkV5.gif

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com/email-signature Version: 2016.0.7996 / Virus Database: 4749/13697 - Release Date: 01/03/17

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com/email-signature Version: 2016.0.7996 / Virus Database: 4749/13697 - Release Date: 01/03/17

mdeutch3 commented 7 years ago

Some of the METOC symbols do have RGB for the fill specified in table C-III, e.g. Oceanography/Bioluminescence VDR Level 1-2 is RGB 26:153:77