search

missionpinball / mpf-gmc

Godot-based Media Controller for the MPF pinball framework
MIT License
5 stars 1 forks source link

fixes #3 trim .remap suffix #4

Closed mpcarr closed 1 month ago

mpcarr commented 1 month ago

If the filename ends with .remap, this update trims the filename so the slides lookups resolve.

avanwinkle commented 1 month ago

My apologies, I didn't see these open PRs when reviewing the issues you filed and correcting them. The new implementation avoids directory traversal on exported projects entirely, which is better for everyone.

I've tried adjusting my github notifications so I'll get emails for new issues and PRs, so in the future I'll be able to see your contributions and approve the PRs instead of re-doing what you've already done. Thanks so much!