missionpinball / mpf-mc

The Mission Pinball Framework Media Controller. Controls graphics, sounds, DMDs, and LCD displays in MPF.
http://missionpinball.org
MIT License
21 stars 42 forks source link

Bugfix: Sound player delays dropping subsequent sounds #471

Closed avanwinkle closed 1 month ago

avanwinkle commented 1 month ago

A bug was discovered in MPF-MC SoundPlayer where adding a sound with delay would end the sound player processing loop, potentially discarding additional sounds passed in the same payload.

This is because the delay check calls return instead of continue, thus aborting the loop through all sounds passed.

This PR changes the call to continue, as well as for a few other error checks that also called return and would prevent subsequent sounds in the payload from playing.

Manually tested.