search

missionpinball / mpf-monitor

Graphical utilty which connects to MPF to let you visually control, troubleshoot, and see the status of the machine
http://missionpinball.org
MIT License
11 stars 10 forks source link

Render diverters #22

Closed jabdoa2 closed 2 years ago

jabdoa2 commented 5 years ago

Render diverters as a shape on the playfield (just like switches or lights but another shape). Turn them purple when active.

kylenahas commented 4 years ago

@jabdoa2, what shape would you like them to be? Triangles?

jabdoa2 commented 4 years ago

Yeah why not. The idea was to display the state of devices such as diverters. The same may work for magnets or logic blocks.

kylenahas commented 4 years ago

Where would be an appropriate place to define device specific default display rules? I wouldn’t mind hardcoding them, but I think it would be neat to have it be user definable somehow (which would be useful for devices that haven’t yet been implemented in MPF).

I’m not sure if the monitor.yaml file is or is not the place to put this. I could see the benefit of not cluttering up the already verbose file, but it’s pretty busy to begin with.

I’d hesitate putting it in the program level config since it’s hard to access and you might not want it to be the same on every monitor project.

My gut says monitor.yaml.

On Jul 28, 2020, at 11:45 PM, jabdoa2 notifications@github.com wrote:

Yeah why not. The idea was to display the state of devices such as diverters. The same may work for magnets or logic blocks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

atummons commented 2 years ago

This is already completed. devices.py lines 138-144