search

missionpinball / mpf

Mission Pinball Framework: Open source software to run a real pinball machine.
http://missionpinball.org
MIT License
215 stars 142 forks source link

FAST Platform: NC EOS switches #1717

Open toomanybrians opened 11 months ago

toomanybrians commented 11 months ago

In MPF 0.57, it appears the FAST platform is not respecting NO versus NC for EOS switches in flipper configs. The unit tests do not cover this.

toomanybrians commented 11 months ago

It looks like something isn’t working here. When the flipper button associated with the flipper goes inactive, it sends a TL:xx,02 command to disable the flipper. 🤷‍♂️ I would guess this has nothing to do with the NC EOS and is an EOS thing in general in 0.57, but who knows. I’ll try to set up some tests to reproduce this.

toomanybrians commented 11 months ago

Log showing the flipper autofires disabling:

2023-10-15 12:49:55,861 : INFO : SwitchController : <<<<<<< 's_left_flipper' inactive >>>>>>>
2023-10-15 12:49:55,861 : DEBUG : FAST Driver : Disabling driver 30
2023-10-15 12:49:55,861 : DEBUG : FAST Driver : Disabling driver 25
2023-10-15 12:49:55,861 : INFO : [NET] : >>>> TL:1E,02
2023-10-15 12:49:55,861 : INFO : [NET] : >>>> TL:19,02

I wrote a test which passes. 🤷‍♂️ The only thing I can think of is the tests don't have a game running, so maybe something there affects it? I cannot reproduce this locally, so who knows?