search

missionpinball / mpf

Mission Pinball Framework: Open source software to run a real pinball machine.
http://missionpinball.org
MIT License
217 stars 143 forks source link

Add shot block test cases #1828

Closed bosh closed 2 months ago

bosh commented 3 months ago

I've been learning about shot blocking and I realized through testing that the MPF docs are incorrect (on https://github.com/missionpinball/mpf-docs/blob/main/docs/config/shot_profiles.md ) about the default behavior of Block.

In order to prove that the default behavior is as block: False instead of True, I've added test cases for the False and True options. (config_spec:1617 for shot_profiles:block shows the default to be false as well)

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bosh commented 3 months ago

It looks like the three failures in linting are preexisting on dev