search

missionpinball / mpf

Mission Pinball Framework: Open source software to run a real pinball machine.
http://missionpinball.org
MIT License
217 stars 143 forks source link

Segment display replace #1840

Open mpcarr opened 2 months ago

mpcarr commented 2 months ago

This PR addresses issue #1839. The newly added replace feature ([https://github.com/missionpinball/mpf/pull/1779](Segment Displays: Stack vs Replace Option).

This update using the current states color, flashing and flash_mask settings for the incoming text if non are specified on the segment_display_player. Without this, the text isn't displayed due the the color being missing and the text is set to flash.

Additionally this update removes the text from the display when the update method is not stack.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

avanwinkle commented 2 months ago

Thanks for the input, have you looked at https://github.com/missionpinball/mpf/pull/1820 to see where your respective changes align/diverge?