missionpinball / mpf

Mission Pinball Framework: Open source software to run a real pinball machine.
http://missionpinball.org
MIT License
214 stars 142 forks source link

Support for "always closed" switches #936

Open toomanybrians opened 7 years ago

toomanybrians commented 7 years ago

WPC machines have an "always closed" switch (not an actual switch, just a diode across the row/column) which is used for troubleshooting. If the game boots up and the always closed switch is open, the machine knows there's an issue (fuse or other problem) with the switch matrix.

I propose we add this to MPF in the form of an "always_closed" tag for switches. Maybe add the checking to the switch controller? Or to the switch? If an always closed switch is ever open, we can post an event which could then be used for a slide player to explain the problem.

I know that this is possible to manually implement with switch events and conditional events that could run at startup, but that would require a couple of entries in the event player, and I wonder if this is something we should build in since it's somewhat common? (Or not, because again it's just a few lines in the event player and I could do it in a how to guide.)

Thoughts?

jabdoa2 commented 7 years ago

I guess we should include this in the service mode. It should check on start and maybe in some kind of diagnostic menu entry.