search

missive / emoji-mart

🏪 One component to pick them all
https://missiveapp.com/open/emoji-mart
MIT License
8.59k stars 826 forks source link

[Feature] Emoji only in categories if native is present. #13

Closed rachitGulati closed 7 years ago

rachitGulati commented 7 years ago

I want to render the emoji's in the sheet only if native support icon is present. Can you please suggest where should I change ?.

EtienneLem commented 7 years ago

Do you have a few examples of emojis that wouldn’t have a native version? I guess it mostly depends on the device/OS. It would help to to know which ones aren’t supported on what device to test the implementation.

We could add a onlyIfNativeIsSupported props to the Picker component.

rachitGulati commented 7 years ago

So in the image below you can see inside the native there is box "[]" instead of emoji face. I am on Mac OS X Yosemite with Chrome 53.0.2785.

screenshot 2016-10-04 11 18 01

And there are many emoji which are showing this. I am currently using apple sprite. I wanted the native emoji to be shown in my textArea or in input field.

Is there any hotfix for this ? Can you guide me what should I do for it ?

rachitGulati commented 7 years ago

@EtienneLem Any update ? I am sorry for bothering you but it's a bit urgent for me :( . I would really appreciate any help from your side.

EtienneLem commented 7 years ago

So I gave it a go, but it doesn’t seem to work. Check out https://missive.github.io/emoji-mart and check the excludeUnsupportedNativeEmojis checkbox, the Upside-Down Face is still there, correct?

rachitGulati commented 7 years ago

I don't know what you have fixed but it seems to be working now at least in your demo . Showing right value for 'native' property of the object inside the console. Don't think so checkbox is even working.

rachitGulati commented 7 years ago

Closing this issue as it is not reproducing any more :)

@EtienneLem thanks for fixing it :)