search

missive / emoji-mart

🏪 One component to pick them all
https://missiveapp.com/open/emoji-mart
MIT License
8.59k stars 826 forks source link

No Emoji Found is not being translated #142

Closed adferras closed 6 years ago

adferras commented 6 years ago

Even though we have populated translations for "No Emoji Found", emoji-mart is not using them.

Here are our translations:

screen shot 2017-11-07 at 2 11 28 pm

Here you can see that search and select is using our translations, but not No Emoji Found.

screen shot 2017-11-07 at 2 09 36 pm

The text is definitely being used via https://github.com/missive/emoji-mart/blob/35c05eb62d1dbf683c3a3f228a05b1df177dc181/src/components/category.js#L201, but we are unable to override it with our own translation.

EtienneLem commented 6 years ago

🤔 Will look into, thanks!

EtienneLem commented 6 years ago

Ah! Pretty sure you’re actually using an outdated version, here’s how it looks now:

screen shot 2017-11-07 at 7 24 22 pm

I recall notfound being overlooked at first, see 046d489d7ff23f70867744fe4f57d11234a7f087