search

missive / emoji-mart

🏪 One component to pick them all
https://missiveapp.com/open/emoji-mart
MIT License
8.59k stars 826 forks source link

Missing emojis are still `rendered` causing layout issues #160

Closed pederjohnsen closed 6 years ago

pederjohnsen commented 6 years ago

Missing emojis are still rendered in the picker causing layout issues https://i.imgur.com/PCMHkXl.png?1

It seems weird to render them if there is no emoji to display.

ajbeaven commented 6 years ago

I think perhaps #158 will resolve this. It's merged but not yet released.

EtienneLem commented 6 years ago

These are native emojis, correct? There’s not much we can do to prevent that from happening. Support is different depending on the OS and browser being used, so it needs to be tested at runtime. There’s a branch (https://github.com/missive/emoji-mart/tree/exclude-unsupported-native-emojis) with an experiment, but it has proven not to be 100% reliable and most likely poor for performance. It requires writing and reading dataURL from a canvas for each emoji.

Using native emojis is much faster and always look sharper, but unfortunately has important drawbacks.

@ajbeaven Oh thanks for the reminder, I’ll do that today.