search

misskey-dev / mfm.js

An MFM parser implementation with TypeScript.
MIT License
108 stars 19 forks source link

Use MfmUrl AST in MfmLink AST #126

Open shibaobun opened 1 year ago

shibaobun commented 1 year ago

What

Why

Additional info (optional)

This is my first time using typescript, so please let me know if there's anything that can be changed for best practice! Thank you!

codecov[bot] commented 1 year ago

Codecov Report

Merging #126 (88daccc) into develop (ae92c2a) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 88daccc differs from pull request most recent head e7f70c6. Consider uploading reports for the commit e7f70c6 to get more accurate results

@@           Coverage Diff            @@
##           develop     #126   +/-   ##
========================================
  Coverage    97.72%   97.73%           
========================================
  Files            8        8           
  Lines         1541     1544    +3     
  Branches       317      233   -84     
========================================
+ Hits          1506     1509    +3     
- Misses          33       34    +1     
+ Partials         2        1    -1
Impacted Files Coverage Δ
src/internal/parser.ts 99.33% <100.00%> (ø)
src/internal/util.ts 97.63% <100.00%> (ø)
src/node.ts 100.00% <100.00%> (ø)
src/api.ts 100.00% <0.00%> (ø)
src/internal/index.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

shibaobun commented 1 year ago

@syuilo i've rebased this PR with your changes, please let me know if there's anything you'd like changed!