search

misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.99k stars 1.36k forks source link

duplicated results for user search #10432

Closed tassoman closed 11 months ago

tassoman commented 1 year ago

💡 Summary

searching for users, some results are duplicated

🥰 Expected Behavior

I don't expect to find duplicated cards of the same profile

🤬 Actual Behavior

immagine

📝 Steps to Reproduce

  1. open new user search page
  2. search an user
  3. see same profile twice

📌 Environment

Misskey version: 13.10.3 Your OS: docker Your browser: any

tassoman commented 1 year ago

First and last are duplicated (local profile)

immagine

Nanashia commented 1 year ago

confirmed.

/search の ユーザー検索は users/search エンドポイントを使いますが、 users/search はuntilId指定をサポートしておらずoffset指定のみです。 https://github.com/misskey-dev/misskey/blob/develop/packages/backend/src/server/api/endpoints/users/search.ts#L130

しかしfrontendではoffsetModeをしておらず、 untilIdでpaginationしようとします。 https://github.com/misskey-dev/misskey/blob/develop/packages/frontend/src/pages/search.vue#L97

結果としてpaginationができておらず、検索結果の先頭ユーザーが繰り返し表示されてしまっています。

tassoman commented 1 year ago

In version 13.13.2 this has been transformed into an endless infinite loop search 😆

Kazam_screencast_00029.webm

tassoman commented 11 months ago

Fixed in 2023.11.0
Can't reproduce