misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.99k stars 1.36k forks source link

Ignore target note's visibility for quote renote visibility (e.g. allow quote renotes to be Public where the target post is Unlisted) #12864

Open temtemy opened 9 months ago

temtemy commented 9 months ago

💡 Summary

For some reason even though quote's visibility is explicitly set to Public (and for some reason too it defaults to Public instead of the visibility of the target post), when the target post is Unlisted (or "Home" visibility in Misskey) the quote will also be set to Unlisted regardless of the visibility you set for it.

🥰 Expected Behavior

The visibility setting of the quote renote first and foremost should be by default set to the same visibility as the target note.

And quote renoting in Public should always be possible for quotable posts.

🤬 Actual Behavior

Default visibility is set to Public regardless of the target post's visibility

Quote renoting posts whose visibility is "Home" will always be Unlisted/Home regardless of what the visibility setting is at

📝 Steps to Reproduce

No response

💻 Frontend Environment

* Model and OS of the device(s): Windows 11 22H2 x64
* Browser: Floorp 11.7.1
* Server URL: makai.chaotic.ninja
* Misskey: 2023.11.1

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

temtemy commented 9 months ago

Since this issue got a -1 let me share a user story I devised myself to show why I think it would be useful to see this issue resolved:

Say I posted a Public note. And then at some point in the future, I follow-up to it via a reply. But I'm mindful of avoiding spamming my instance's local timeline, so to prevent that I set my follow-up reply's visibility to Home (since the local timeline will only show Public posts). And then at some point too I realized that the follow-up I did could be pretty useful standalone, and I want other people to discover it via hashtags. However, in order for hashtags to work, the post has to be Public, and since I can't currently edit my own notes (it's probably too late to "delete and edit" anyway without sacrificing the traction you got), and replies will always respect the parent's visibility (which makes sense), the only option I got is a quote renote. Misskey's UI tells me that the visibility will be Public, and after put in the hashtags I want and click Publish, I just realized that Misskey is lying to me and the quote's visibility got set to Home anyway. Which means there's zero way to make your Home/Unlisted post discoverable without doing the old-fashioned way of copy-pasting the link into your note. And I don't want that because it doesn't immediately show the note's contents to other users (and therefore necessitates a click just to see what I'm quoting myself about), and it doesn't have the same effect as boosting a post does.

Does this convince you somewhat @saschanaz?

Sayamame-beans commented 9 months ago

In my opinion, it's not a good idea to be able to expand visibility against the will of the post author. As a compromise, how do you think about making one's own home post quotable in a public post? (I'm not sure whether federation would work properly, since I feel Misskey (or ActivityPub) does not intended for that.)

temtemy commented 9 months ago

Yeah I'm fine with that @Sayamame-beans. I guess if someone got permission from the post author they could just ask that author to quote their own post publicly and then quote that quote renote yourself. Pretty clunky IMO but should at least give all users peace of mind that their post's visibility is being respected...

saschanaz commented 9 months ago

Oh, so this is about being able to quote your own home-only post publicly. I guess that's fine-ish, except it's still kinda abusable. For now any interaction with non-public-visibility post remains non-public, but with the proposed exception one can quote their own reply to a non-public post.

Perhaps the exception can be limited to non-reply posts.

temtemy commented 9 months ago

I personally don't really see the problem with doing a Public quote renote of an Unlisted/Home note (and you can't boost a followers-only post anyway), since they're both effectively visible to all users anyway when viewed from the poster's profile... But whatever, I'm fine with this compromise.

temtemy commented 7 months ago

By the way Mastodon and Pleroma allow users to force the visibility of their reply to Public even if the parent post's visibility is Unlisted/Home, so I'm not sure if Misskey going its own way in this front even makes sense here.

temtemy commented 7 months ago

Please look at this Misskey note and its replies and quote from the remote instances' view: https://makai.chaotic.ninja/notes/9r76dbr4rw

ledlamp commented 7 months ago

Akkoma doesn't

saschanaz commented 7 months ago

I'd rather discuss why Mastodon's behavior makes sense at all and whether it's intentional or a bug.

temtemy commented 7 months ago

I'd rather discuss why Mastodon's behavior makes sense at all and whether it's intentional or a bug.

I suspect it might be due to the fact that Unlisted posts are not discoverable at all in Mastodon, even when hashtags are used. Misskey meanwhile will happily show Home visibility posts in hashtag timelines.

But yeah probably a good idea to ask them first

saschanaz commented 7 months ago

I tried to search in their issue tracker after posting the comment but couldn't find anything useful 👀

Edit: I do think matching the behavior makes sense if Mastodon has a good reason to keep their behavior.

Sayamame-beans commented 3 months ago

revisit

saschanaz commented 3 months ago

投稿者本人はホーム投稿をパブリックでRN/引用出来るようにすることを提案

公開範囲の変更が不可能っていう制限をなんとか乗り越える方法としていいと思います