misskey-dev / misskey

🌎 An interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.64k stars 1.28k forks source link

fix(backend): Remove @types/node-fetch #13948

Closed woxtu closed 1 week ago

woxtu commented 3 weeks ago

What

@types/node-fetchを消して pnpm install するときに出る警告を解決します。

Why

Since 3.x types are bundled with node-fetch, so you don't need to install any additional packages. https://github.com/node-fetch/node-fetch?tab=readme-ov-file#typescript

Additional info (optional)

Checklist

github-actions[bot] commented 3 weeks ago

このPRによるapi.jsonの差分

差分はこちら ```diff ```

Get diff files from Workflow Page

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.90%. Comparing base (43cccaa) to head (ff9fef4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #13948 +/- ## ============================================ - Coverage 77.84% 64.90% -12.95% ============================================ Files 185 987 +802 Lines 25595 112658 +87063 Branches 487 4484 +3997 ============================================ + Hits 19924 73116 +53192 - Misses 5664 39511 +33847 - Partials 7 31 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 1 week ago

🙏🏻