misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.93k stars 1.34k forks source link

fix(backend): チャート生成時にinstance.isSuspendedが読まれてしまう問題の修正 #13951

Closed tai-cha closed 3 months ago

tai-cha commented 3 months ago

What

13861 の変更に伴ってDB上からはinstanceに対してisSuspendedがなくなったが残っていたのでチャート生成時にエラーが出ていたので置き換えた

Why

参照できない旨のエラーが出ていたため

Additional info (optional)

インスタンス一覧での絞り込みが失敗する問題に関しては#13945 ですでに修正PRがあるので残り部分の修正

Checklist

github-actions[bot] commented 3 months ago

このPRによるapi.jsonの差分

差分はこちら ```diff ```

Get diff files from Workflow Page

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (8f833d7) to head (122ac34).

Files Patch % Lines
...ckages/backend/src/core/chart/charts/federation.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #13951 +/- ## =========================================== - Coverage 65.01% 64.91% -0.10% =========================================== Files 989 989 Lines 112995 112995 Branches 5790 5777 -13 =========================================== - Hits 73460 73352 -108 - Misses 38093 38201 +108 Partials 1442 1442 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 3 months ago

🙏