misskey-dev / misskey

🌎 An interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.63k stars 1.28k forks source link

should Misskey avoid external `<iframe>` for the mascot-web? #14010

Open KisaragiEffective opened 1 week ago

KisaragiEffective commented 1 week ago
          you can also add external iframe on your list (show in classic UI view)

Sans titre

Originally posted by @Albirew in https://github.com/misskey-dev/misskey/issues/7043#issuecomment-1399567669

(個人的な意見: これが問題になることってあるだろうか?)

kakkokari-gtyih commented 1 week ago

これが問題になることってあるだろうか?

(misskey-devのorgが乗っ取られたりGitHub Pagesがサ終したりするようなことがない限り)特にないと思う

強いて言えばCSPの設定がまずいと当該フレームが表示されないくらい

KisaragiEffective commented 1 week ago

cc #9863 ?

kakkokari-gtyih commented 1 week ago

別にそれについてもmascot-webのフレームを通すようにすればいいだけの話なのでこれ以上何ってこともないと思うけど

KisaragiEffective commented 1 week ago

ならこれはcloseしても良いやつかな

KisaragiEffective commented 1 week ago

閉じる

Albirew commented 1 week ago

my point was we should not need to depend on 3rd party website for content. For the same reason as why external CDN are disappearing: privacy.

つまり言いたかったのはコンテンツに第三者は出来る限りに頼るべきじゃ無い。 CDNはどんどん無くなると同じ意味で:プライバシー。

KisaragiEffective commented 1 week ago

@syuilo said in https://github.com/misskey-dev/misskey/pull/8901#issuecomment-1173736019:

このリポジトリに入れたからと言って強制的にAGPLになるわけではないから入れても良さそう でもあんまりバイナリ入れたくない

Albirew commented 1 week ago

oh, ok. following question is completely optional as syuilo's answer is fine in it's own.

would it be possible to add an option (either in .config/default.yml or admin panel) that would download and store it locally if enabled and files are not already present?

kakkokari-gtyih commented 1 week ago

would it be possible to add an option (either in .config/default.yml or admin panel) that would download and store it locally if enabled and files are not already present?

for ai-chan mascot, it's impossible because of Live2D's commercial license

kakkokari-gtyih commented 1 week ago

hosting live2d-related thing by yourself requires you to comply live2d license and might require you to pay license fee

https://www.live2d.com/en/sdk/license/

Albirew commented 1 week ago

Ah, i got it. I was thinking only as a non-profit entity or as the Misskey-dev's point of view, but if companies want to use Misskey, they would have to pay live2d for hosted content. Issue can be re-closed. PS: @KisaragiEffective can you rename issue to "mascot-web external iframe hosting" ? so people can better find this issue when searching. Thanks.

kakkokari-gtyih commented 1 week ago

if companies want to use Misskey, they would have to pay live2d for hosted content

yes, if the mascot is self-hosted. Since Live2D's proprietary code is NOT included in the misskey at this time, you don't have to pay to Live2D inc.

kakkokari-gtyih commented 1 week ago

(off-topic) Live2Dを利用して製作されたmisskey-devのサイトをiframeで埋め込んだ場合ライセンス費用(どこに請求されるのか、売上金の計算はどうするのか)はどうなるのかなどについて確認しておいたほうがいいかも?

KisaragiEffective commented 1 week ago

off-topic: 埋め込んだ場合、運用元の売り上げや寄付金を受け取る規模が大きいとライセンス料が発生しそう

KisaragiEffective commented 1 week ago

@Albirew wrote:

PS: @KisaragiEffective can you rename issue to "mascot-web external iframe hosting" ? so people can better find this issue when searching. Thanks.

Indeed, done 👍🏻