misskey-dev / misskey

🌎 An interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.63k stars 1.28k forks source link

fix(frontend): Enable to iterate over DOM collections #14040

Closed woxtu closed 1 week ago

woxtu commented 1 week ago

What

dom.iterableを追加してHTMLCollectionをiterableにします。

Why

次のTypeScriptエラーを解決したい:

src/scripts/theme.ts(87,20): error TS2488: Type 'HTMLCollection' must have a '[Symbol.iterator]()' method that returns an iterator.

Additional info (optional)

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.84%. Comparing base (f37d684) to head (fe1d580).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14040 +/- ## =========================================== + Coverage 77.79% 77.84% +0.05% =========================================== Files 184 185 +1 Lines 25536 25600 +64 Branches 487 487 =========================================== + Hits 19865 19929 +64 Misses 5664 5664 Partials 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KisaragiEffective commented 1 week ago

@syuilo マージしても良いですか and/or マージしますか?

syuilo commented 1 week ago

🙏