Open BlankEclair opened 2 months ago
Settings UI mockup:
The mockup was created by editing the code: settings-mockup.diff.gz
Here are my ideas for the implementation: Three fields are sent to the client and are federated:
manualCatEarColor
(bool): Set to true when the "Manually set cat ear color" toggle is enabled. Set to false otherwiseouterCatEarColor
(string): Color of the outer part of the cat ears (in the format #RRGGBB
). Always setโthe client should only use it when isCat
and manualCatEarColor
are both true. If the user never set the setting, then it should be some default value (maybe #5b6880, but I don't really mind about the exact color)innerCatEarColor
(string): See above but for the inner part of the earsIs this okay? (And can I be assigned this issue?)
I'm eagerly awaiting this feature.
@BlankEclair
Looks good for me with a nit: I'd name it overrideCatEarColor
(yes, it's bike-shredding).
I'm going to assign you.
ใชใใใใใชใๆนๅใซๅพใใฆใใฟใใใ ใใฉๅไบบ็ใซใฏใปใใ
Based on internal discussions with core members, this feature is unlikely to be merged because federation needs detailed consideration and we cannot pay such a costs for low-priority features like cat ears.
Sorry for rejecting after assigning you due to lack of communication with members.
realy need consider federation? I think this feature most important point is "I want look me I desire myself" your eyes on another instances?
memberใธ: ๆใใจใใใใใฃใใฎใงๅฅใงdiscussionใๅใใพใ ้ๅ
ฌๅผใซ่งฃๆฑบๆธใฟ
I think it is inappropriate that isCat
is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers.
Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.
It should not have been closed when there were still objections.
Since there are negative opinions about adding properties to the federation (although I am positive about it), let's first try implementing it without federation.
ๆๅใซ: ็งใฏๆฎๆฎตisCatใซใใฆใใชใใฎใงใใใฎๆฉ่ฝใๆฌฒใใใใฉใใใฏ็นใซๅ้กใงใฏใใใพใใใ
็งใๆฐใซใใฆใใ็นใฏไธปใซไปฅไธใฎ๏ผ็นใงใใ
ใใใใฃใฆใใใๅฐใใใคใผใใใค่ช ๅฎใซๅใๅใฃใฆใใใใจๆใใพใใใใใใใใ
First of all, since I don't usually use isCat, whether I want this feature or not isn't particularly important to me.
The points I am concerned about are mainly the following two:
I considered the issue with isCat color to be more of a self-identity issue rather than a technical problem. The willingness to contribute, and the stance of closing the issue without discussion for the reason that "the implementation cost cannot be covered due to internal discussions" for a first-time contribution. Therefore, I thought it would be better to approach this more naively and sincerely.
ใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใใ
็งใฏใใใๅฎ่ฃ ใใใใจๅใ็ตใใงใใพใ
็งใฏใใใๅฎ่ฃ ใใใใจๅใ็ตใใงใใพใ
Sorry, I just finished creating my pull request right after you sent that.
็งใฏใใใๅฎ่ฃ ใใใใจๅใ็ตใใงใใพใ
Sorry, I just finished creating my pull request right after you sent that.
I, too, just finished the implementation. I will use that one when your pull request is merged.
I think it is inappropriate that isCat is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers. Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.
It will probably be another case of where Sharkey will implement the federation of the colors on our side as it is not "high cost" to add federation as shown by the fact that we got editing in federation with all fediverse platforms that support it as well as custom profile backgrounds in federation with Akkoma.
Considering all this is is just 2 text fields with hex color codes which can easily be checked against.
I think it is inappropriate that isCat is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers.
Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.
It will probably be another case of where Sharkey will implement the federation of the colors on our side as it is not "high cost" to add federation as shown by the fact that we got editing in federation with all fediverse platforms that support it as well as custom profile backgrounds in federation with Akkoma.
Considering all this is is just 2 text fields with hex color codes which can easily be checked against.
ใใงใซไปใฎใใฉใผใฏใใใฃใฆใใใใโฆ?(ๆช็ขบๅฎ)
Summary
After enabling "Mark this account as a cat", I would like three extra settings: "Manually set cat ear color", "Set outer cat ear color", and "Set inner cat ear colors". The last two would only show when "Manually set cat ear color" is enabled. This would allow setting both cat ear colors:![](https://github.com/misskey-dev/misskey/assets/170076830/8d32dc95-1fe4-4037-9308-31466553472b)
Purpose
Personally, the algorithm used to generate the cat ear colors of my profile picture uses a color that I do not really like, and I don't want to change my profile picture. I also would like to set the inner cat ear color to change it to another shade of blue.
(I use a fork of Misskey called Sharkey, but I think it is better to request this to Misskey so that all Misskey forks support it)
I have also found another user wanting this: https://lethallava.land/notes/9jc6rl2gvqkq6v2e
Do you want to implement this feature yourself?