misskey-dev / misskey

๐ŸŒŽ An interplanetary microblogging platform ๐Ÿš€
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.82k stars 1.32k forks source link

Add the ability to change cat ear colors #14178

Open BlankEclair opened 2 months ago

BlankEclair commented 2 months ago

Summary

After enabling "Mark this account as a cat", I would like three extra settings: "Manually set cat ear color", "Set outer cat ear color", and "Set inner cat ear colors". The last two would only show when "Manually set cat ear color" is enabled. This would allow setting both cat ear colors:

Purpose

Personally, the algorithm used to generate the cat ear colors of my profile picture uses a color that I do not really like, and I don't want to change my profile picture. I also would like to set the inner cat ear color to change it to another shade of blue.

(I use a fork of Misskey called Sharkey, but I think it is better to request this to Misskey so that all Misskey forks support it)

I have also found another user wanting this: https://lethallava.land/notes/9jc6rl2gvqkq6v2e

Do you want to implement this feature yourself?

BlankEclair commented 2 months ago

Settings UI mockup:

The mockup was created by editing the code: settings-mockup.diff.gz

BlankEclair commented 1 month ago

Here are my ideas for the implementation: Three fields are sent to the client and are federated:

Is this okay? (And can I be assigned this issue?)

nennneko5787 commented 1 month ago

I'm eagerly awaiting this feature.

KisaragiEffective commented 1 month ago

@BlankEclair Looks good for me with a nit: I'd name it overrideCatEarColor (yes, it's bike-shredding). I'm going to assign you.

tamaina commented 1 month ago

ใชใ‚“ใ‹ใ‚„ใ‚‰ใชใ„ๆ–นๅ‘ใซๅ‚พใ„ใฆใ‚‹ใฟใŸใ„ใ ใ‘ใฉๅ€‹ไบบ็š„ใซใฏใปใ—ใ„

anatawa12 commented 1 month ago

Based on internal discussions with core members, this feature is unlikely to be merged because federation needs detailed consideration and we cannot pay such a costs for low-priority features like cat ears.

Sorry for rejecting after assigning you due to lack of communication with members.

fruitriin commented 1 month ago

realy need consider federation? I think this feature most important point is "I want look me I desire myself" your eyes on another instances?

KisaragiEffective commented 1 month ago

memberใธ: ๆ€ใ†ใจใ“ใ‚ใŒใ‚ใฃใŸใฎใงๅˆฅใงdiscussionใ‚’ๅˆ‡ใ‚Šใพใ™ ้žๅ…ฌๅผใซ่งฃๆฑบๆธˆใฟ

kakkokari-gtyih commented 1 month ago

I think it is inappropriate that isCat is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers. Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.

tamaina commented 1 month ago

It should not have been closed when there were still objections.

Since there are negative opinions about adding properties to the federation (although I am positive about it), let's first try implementing it without federation.

fruitriin commented 1 month ago

ๆœ€ๅˆใซ: ็งใฏๆ™ฎๆฎตisCatใซใ—ใฆใ„ใชใ„ใฎใงใ€ใ“ใฎๆฉŸ่ƒฝใŒๆฌฒใ—ใ„ใ‹ใฉใ†ใ‹ใฏ็‰นใซๅ•้กŒใงใฏใ‚ใ‚Šใพใ›ใ‚“ใ€‚

็งใŒๆฐ—ใซใ—ใฆใ„ใ‚‹็‚นใฏไธปใซไปฅไธ‹ใฎ๏ผ’็‚นใงใ™ใ€‚

ใ—ใŸใŒใฃใฆใ€ใ‚‚ใ†ๅฐ‘ใ—ใƒŠใ‚คใƒผใƒ–ใ‹ใค่ช ๅฎŸใซๅ‘ใๅˆใฃใฆใ‚‚ใ‚ˆใ„ใจๆ€ใ„ใพใ—ใŸใ€‚ใ€€ใ€€ใ€€ใ€€ใ€€


First of all, since I don't usually use isCat, whether I want this feature or not isn't particularly important to me.

The points I am concerned about are mainly the following two:

I considered the issue with isCat color to be more of a self-identity issue rather than a technical problem. The willingness to contribute, and the stance of closing the issue without discussion for the reason that "the implementation cost cannot be covered due to internal discussions" for a first-time contribution. Therefore, I thought it would be better to approach this more naively and sincerely.

ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€ใ€€

nennneko5787 commented 1 month ago

็งใฏใ“ใ‚Œใ‚’ๅฎŸ่ฃ…ใ—ใ‚ˆใ†ใจๅ–ใ‚Š็ต„ใ‚“ใงใ„ใพใ™

BlankEclair commented 1 month ago

็งใฏใ“ใ‚Œใ‚’ๅฎŸ่ฃ…ใ—ใ‚ˆใ†ใจๅ–ใ‚Š็ต„ใ‚“ใงใ„ใพใ™

Sorry, I just finished creating my pull request right after you sent that.

nennneko5787 commented 1 month ago

็งใฏใ“ใ‚Œใ‚’ๅฎŸ่ฃ…ใ—ใ‚ˆใ†ใจๅ–ใ‚Š็ต„ใ‚“ใงใ„ใพใ™

Sorry, I just finished creating my pull request right after you sent that.

I, too, just finished the implementation. I will use that one when your pull request is merged.

Mar0xy commented 1 month ago

I think it is inappropriate that isCat is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers. Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.

It will probably be another case of where Sharkey will implement the federation of the colors on our side as it is not "high cost" to add federation as shown by the fact that we got editing in federation with all fediverse platforms that support it as well as custom profile backgrounds in federation with Akkoma.

Considering all this is is just 2 text fields with hex color codes which can easily be checked against.

nennneko5787 commented 1 month ago

I think it is inappropriate that isCat is federated but not the properties related to ear color, as this would cause inconsistencies in the profiles across servers.

Also, some people have suggested that federation is not necessary, but it is inevitable that there will be people who would like it to be federated as long as these properties are implemented internally, and I am sure one day we will take that into consideration.

It will probably be another case of where Sharkey will implement the federation of the colors on our side as it is not "high cost" to add federation as shown by the fact that we got editing in federation with all fediverse platforms that support it as well as custom profile backgrounds in federation with Akkoma.

Considering all this is is just 2 text fields with hex color codes which can easily be checked against.

ใ™ใงใซไป–ใฎใƒ•ใ‚ฉใƒผใ‚ฏใŒใ‚„ใฃใฆใ‚‹ใ‚‰ใ—ใ„โ€ฆ?(ๆœช็ขบๅฎš)