fix(backend): リバーシの設定変更が反映されないのを修正

kakkokari-gtyih commented 2 months ago

What

リバーシの対局設定が変更できないのを修正
updateする際のバリデーションをちゃんと書いた（正しいか要確認）

Why

Fix #14397

Additional info (optional)

Checklist

[x] Read the contribution guide
[ ] Test working in a local environment
[ ] (If needed) Add story of storybook
[x] (If needed) Update CHANGELOG.md
[ ] (If possible) Add tests

github-actions[bot] commented 2 months ago

このPRによるapi.jsonの差分

差分はこちら

```diff ```

Get diff files from Workflow Page

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 41.74%. Comparing base (41936c1) to head (7e7e999). Report is 5 commits behind head on develop.

Files	Patch %	Lines
packages/backend/src/core/ReversiService.ts	25.00%	21 Missing :warning:
...end/src/server/api/stream/channels/reversi-game.ts	20.00%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #14404 +/- ## =========================================== + Coverage 39.91% 41.74% +1.83% =========================================== Files 1545 1549 +4 Lines 190505 196580 +6075 Branches 2654 3589 +935 =========================================== + Hits 76046 82070 +6024 - Misses 113898 113949 +51 Partials 561 561 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 2 months ago

@bindThisって基本入れたほうがいいのかしら