misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(frontend): MFM doesn't work in some places #14405

Open zyoshoka opened 2 months ago

zyoshoka commented 2 months ago

What

MFM が機能すべき箇所で機能していないところがある問題を修正します。具体的には

について修正しています。

Why

Closes #8321

Additional info (optional)

ページのヘッダー名については一律でカスタム絵文字のレンダリングを有効にしていますが、どちらかというと PageMetadata に有効の要否を定義するほうがいいのかもしれません

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.49%. Comparing base (1184436) to head (1003cae). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/frontend/src/components/MkChannelPreview.vue 0.00% 3 Missing :warning:
...ackages/frontend/src/components/MkFlashPreview.vue 0.00% 2 Missing :warning:
packages/frontend/src/components/MkPagePreview.vue 0.00% 2 Missing :warning:
packages/frontend/src/ui/deck/main-column.vue 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14405 +/- ## ============================================ - Coverage 39.68% 19.49% -20.20% ============================================ Files 1544 715 -829 Lines 193618 101372 -92246 Branches 3592 986 -2606 ============================================ - Hits 76846 19765 -57081 + Misses 116176 81062 -35114 + Partials 596 545 -51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 2 weeks ago

👀

syuilo commented 2 weeks ago

MkPageWindow, MkToast, main-column でタイトルをMFMとして解釈すべきかは議論の余地がありそう

kakkokari-gtyih commented 2 weeks ago

MkPageWindow, MkToast, main-column でタイトルをMFMとして解釈すべきかは議論の余地がありそう

MFMというよりかは絵文字を表示できるようになるだけ(plain)なので別に良さそうではある

kakkokari-gtyih commented 2 weeks ago

あ、〇〇Preview系もplainのほうが良さそうかも