misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

Multiple reactions #14420

Open syuilo opened 1 month ago

syuilo commented 1 month ago

What

Why

Additional info (optional)

Checklist

kakkokari-gtyih commented 1 month ago

https://github.com/misskey-dev/misskey/pull/14420/commits/cb6a1c773e1c7a73161153b2083358638fbdc3bf 入れる所間違えている疑惑

github-actions[bot] commented 1 month ago

Thank you for sending us a great Pull Request! 👍 Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types
github-actions[bot] commented 1 month ago

このPRによるapi.jsonの差分

差分はこちら ```diff --- base +++ head @@ -80403,6 +80403,9 @@ "pinLimit": { "type": "integer" }, + "reactionsPerNoteLimit": { + "type": "integer" + }, "antennaLimit": { "type": "integer" }, @@ -80449,6 +80452,7 @@ "alwaysMarkNsfw", "canUpdateBioMedia", "pinLimit", + "reactionsPerNoteLimit", "antennaLimit", "wordMuteLimit", "webhookLimit", ```

Get diff files from Workflow Page

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 23.25581% with 33 lines in your changes missing coverage. Please review.

Project coverage is 38.74%. Comparing base (3cd5f86) to head (0ddd4bc). Report is 39 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 19 Missing :warning:
packages/frontend/src/pages/admin/roles.vue 0.00% 7 Missing :warning:
packages/backend/src/core/ReactionService.ts 0.00% 4 Missing :warning:
...ges/backend/src/core/entities/NoteEntityService.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14420 +/- ## =========================================== - Coverage 39.87% 38.74% -1.13% =========================================== Files 1547 1547 Lines 190882 190906 +24 Branches 3506 2415 -1091 =========================================== - Hits 76116 73976 -2140 - Misses 114204 116366 +2162 - Partials 562 564 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 2 weeks ago

自分がいくつリアクションしているかを毎リアクション取得しなければならないからパフォーマンスへの影響が懸念される