kakkokari-gtyih commented 1 month ago

What

Why

14456 が一部修正される

Additional info (optional)

~~https://github.com/misskey-dev/misskey/pull/14484#issuecomment-2323162520 をなんとかする必要がある~~ いけた

Checklist

[x] Read the contribution guide
[x] Test working in a local environment
[ ] (If needed) Add story of storybook
[x] (If needed) Update CHANGELOG.md
[ ] (If possible) Add tests

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 45.07042% with 78 lines in your changes missing coverage. Please review.

Project coverage is 41.28%. Comparing base (89841e4) to head (0f87d6d). Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ackages/frontend/src/components/MkNotification.vue	0.00%	28 Missing :warning:
packages/backend/src/models/Notification.ts	0.00%	8 Missing :warning:
...e/processors/ExportCustomEmojisProcessorService.ts	25.00%	6 Missing :warning:
...queue/processors/ExportAntennasProcessorService.ts	28.57%	5 Missing :warning:
...queue/processors/ExportBlockingProcessorService.ts	28.57%	5 Missing :warning:
...ueue/processors/ExportFavoritesProcessorService.ts	28.57%	5 Missing :warning:
...ueue/processors/ExportFollowingProcessorService.ts	28.57%	5 Missing :warning:
...c/queue/processors/ExportMutingProcessorService.ts	28.57%	5 Missing :warning:
...rc/queue/processors/ExportNotesProcessorService.ts	28.57%	5 Missing :warning:
...ueue/processors/ExportUserListsProcessorService.ts	28.57%	5 Missing :warning:
... and 1 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #14484 +/- ## =========================================== + Coverage 39.57% 41.28% +1.71% =========================================== Files 1544 1548 +4 Lines 193244 199120 +5876 Branches 3563 2604 -959 =========================================== + Hits 76470 82202 +5732 - Misses 116209 116353 +144 Partials 565 565 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 1 month ago

通知にペイロードが乗らないの謎

github-actions[bot] commented 1 month ago

このPRによるapi.jsonの差分

差分はこちら

```diff --- base +++ head @@ -46020,6 +46020,7 @@ "followRequestAccepted", "roleAssigned", "achievementEarned", + "exportCompleted", "app", "test", "pollVote", @@ -46044,6 +46045,7 @@ "followRequestAccepted", "roleAssigned", "achievementEarned", + "exportCompleted", "app", "test", "pollVote", @@ -46259,6 +46261,7 @@ "followRequestAccepted", "roleAssigned", "achievementEarned", + "exportCompleted", "app", "test", "reaction:grouped", @@ -46285,6 +46288,7 @@ "followRequestAccepted", "roleAssigned", "achievementEarned", + "exportCompleted", "app", "test", "reaction:grouped", @@ -78999,6 +79003,50 @@ ] }, { + "type": "object", + "properties": { + "id": { + "type": "string", + "format": "id" + }, + "createdAt": { + "type": "string", + "format": "date-time" + }, + "type": { + "type": "string", + "enum": [ + "exportCompleted" + ] + }, + "exportedEntity": { + "type": "string", + "enum": [ + "antenna", + "blocking", + "clip", + "customEmoji", + "favorite", + "following", + "muting", + "note", + "userList" + ] + }, + "fileId": { + "type": "string", + "format": "id" + } + }, + "required": [ + "id", + "createdAt", + "type", + "exportedEntity", + "fileId" + ] + }, + { "type": "object", "properties": { "id": { ``` [Get diff files from Workflow Page](https://github.com/misskey-dev/misskey/actions/runs/11045777295)