misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

refactor(frontend): 非推奨の表現を改める #14517

Closed kakkokari-gtyih closed 4 weeks ago

kakkokari-gtyih commented 1 month ago

What

Why

Additional info (optional)

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 19.57%. Comparing base (f393b6b) to head (b2f5168). Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...rontend/src/pages/settings/preferences-backups.vue 0.00% 30 Missing :warning:
packages/frontend/src/scripts/code-highlighter.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14517 +/- ## ======================================== Coverage 19.57% 19.57% ======================================== Files 717 717 Lines 100466 100465 -1 Branches 1005 1005 ======================================== Hits 19669 19669 + Misses 80251 80250 -1 Partials 546 546 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 1 month ago

👀

kakkokari-gtyih commented 1 month ago

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

acid-chicken commented 1 month ago

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

7881f06be060dd955499a6beff3ad1967ed628f6 576484835ebe0c896b7fd242c7f8d58b32579da6

kakkokari-gtyih commented 1 month ago

このPRで変えた部分だけi18n.t()を使い続けていた理由とかってあるのかしら

7881f06 5764848

どちらも特に問題なさそうではある(MkPostFormAttaches.vueは時期的に過渡期だった可能性がある。preferences-backups.vueはi18nの書き方が特殊だったから置き換え漏れたとか?)

acid-chicken commented 1 month ago

コミット日付

syuilo commented 4 weeks ago

🙏🏿