misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

refactor(misskey-js): warnを除去 #14520

Closed kakkokari-gtyih closed 1 month ago

kakkokari-gtyih commented 1 month ago

What

https://github.com/misskey-dev/misskey/pull/14508 で重複する条件判定を入れたためmisskey-jsにwarnが出るようになった それを消す

Why

Additional info (optional)

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.55%. Comparing base (567acea) to head (64cdd1f). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14520 +/- ## ============================================ + Coverage 20.16% 41.55% +21.39% ============================================ Files 725 1551 +826 Lines 100579 196719 +96140 Branches 1045 3568 +2523 ============================================ + Hits 20279 81754 +61475 - Misses 79758 114373 +34615 - Partials 542 592 +50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KisaragiEffective commented 1 month ago

自明なのでマージ