misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(frontend): 設定変更時のリロード確認ダイアログが複数個表示されることがある問題を修正 #14543

Closed kakkokari-gtyih closed 3 weeks ago

kakkokari-gtyih commented 1 month ago

What

Why

Fix #14541

Additional info (optional)

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 19.53%. Comparing base (daf9ae5) to head (5f11ff8). Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/scripts/reload-ask.ts 0.00% 39 Missing and 1 partial :warning:
packages/frontend/src/pages/settings/navbar.vue 0.00% 3 Missing :warning:
packages/frontend/src/pages/settings/theme.vue 0.00% 3 Missing :warning:
packages/frontend/src/pages/settings/general.vue 0.00% 2 Missing :warning:
packages/frontend/src/pages/settings/other.vue 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14543 +/- ## ======================================== Coverage 19.53% 19.53% ======================================== Files 713 714 +1 Lines 100375 100375 Branches 997 998 +1 ======================================== Hits 19612 19612 + Misses 80219 80218 -1 - Partials 544 545 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MattyaDaihuku commented 1 month ago

ありがとうございます!

syuilo commented 4 weeks ago

ファイル名と関数名はリロードを尋ねるという情報しかないけど実際は設定の反映のために尋ねる処理になっているから名前と内容を一致させた方が良いわね

kakkokari-gtyih commented 4 weeks ago

askReloadForApplyingSettings とか?

syuilo commented 4 weeks ago

それかaskReloadのままにしてreasonを受け取るようにするアプローチもある

kakkokari-gtyih commented 4 weeks ago

それかaskReloadのままにしてreasonを受け取るようにするアプローチもある

後々使いまわせそうだからそうするか

kakkokari-gtyih commented 4 weeks ago

done

kakkokari-gtyih commented 3 weeks ago

コンフリクト解消

syuilo commented 3 weeks ago

🙏🏿