yunochi commented 3 weeks ago

What

Instead of entering an ID and authenticating with a passkey, create a dedicated 'Login with Passkey' button.
idから入力してpasskey認証をする代わりに、「Passkeyでログインボタン」を作成します

14574

Why

Password-less login accounts have the inconvenience of having to first enter an ID and then click the login button to authenticate the passkey. In addition, multi-account users have the inconvenience of having to enter an ID and then select a passkey from the list. Since Misskey already uses residentKey, it is possible to skip the ID entry process and log in directly by selecting a passkey.

パスワードレスログイン アカウントは、id を最初に入力してからログインボタンを押してパスキー認証をする不便があります。さらに、複数のアカウントを持つユーザーは、id入力後にパスキーリストから選択する必要があるという不便さもあります。 MisskeyはすでにresidentKeyを使用しているため、idを入力するプロセスをスキップしてパスキーを選択してすぐにログインすることが可能です。

Additional info (optional)

WHY Not use conditional mediation
- At the point when a passkey is requested, it is difficult to know whether the user has enabled 'Login without password'.
- Passkeyを要求する時点では、そのユーザーが「パスワードなしでログイン」を有効にしたかどうかを知ることは困難です。

Checklist

[x] Read the contribution guide
[x] Test working in a local environment
[ ] (If needed) Add story of storybook
[x] (If needed) Update CHANGELOG.md
[ ] (If possible) Add tests

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 13.39031% with 304 lines in your changes missing coverage. Please review.

Project coverage is 41.26%. Comparing base (fde94f6) to head (af2d939). Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...kend/src/server/api/SigninWithPasskeyApiService.ts	17.34%	143 Missing :warning:
packages/frontend/src/components/MkSignin.vue	0.00%	86 Missing :warning:
packages/backend/src/core/WebAuthnService.ts	16.25%	67 Missing :warning:
...ackages/backend/src/server/api/ApiServerService.ts	22.22%	7 Missing :warning:
...ackages/frontend/src/components/MkSigninDialog.vue	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #14577 +/- ## =========================================== + Coverage 39.58% 41.26% +1.68% =========================================== Files 1542 1547 +5 Lines 192801 198879 +6078 Branches 2522 2507 -15 =========================================== + Hits 76312 82067 +5755 - Misses 115924 116247 +323 Partials 565 565 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.