misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

Misskey® Reactions Buffering Technology™ #14579

Closed syuilo closed 3 weeks ago

syuilo commented 3 weeks ago

What

Resolve #11093

Why

See #11093

Additional info (optional)

Checklist

github-actions[bot] commented 3 weeks ago

このPRによるapi.jsonの差分

差分はこちら ```diff --- base +++ head @@ -416,6 +416,9 @@ "perUserListTimelineCacheMax": { "type": "number" }, + "enableReactionsBuffering": { + "type": "boolean" + }, "notesPerOneAd": { "type": "number" }, @@ -636,6 +639,7 @@ "perRemoteUserUserTimelineCacheMax", "perUserHomeTimelineCacheMax", "perUserListTimelineCacheMax", + "enableReactionsBuffering", "notesPerOneAd", "backgroundImageUrl", "deeplAuthKey", @@ -13860,6 +13864,9 @@ "perUserListTimelineCacheMax": { "type": "integer" }, + "enableReactionsBuffering": { + "type": "boolean" + }, "notesPerOneAd": { "type": "integer" }, ```

Get diff files from Workflow Page

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 29.83683% with 301 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (4ac8aad) to head (0127b9f). Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/core/ReactionsBufferingService.ts 25.92% 120 Missing :warning:
...ckages/frontend/src/pages/admin/other-settings.vue 0.00% 72 Missing :warning:
...ges/backend/src/core/entities/NoteEntityService.ts 16.92% 54 Missing :warning:
packages/backend/src/core/ReactionService.ts 8.33% 33 Missing :warning:
...rocessors/BakeBufferedReactionsProcessorService.ts 67.50% 13 Missing :warning:
packages/backend/src/server/HealthServerService.ts 0.00% 4 Missing :warning:
...kend/src/server/api/endpoints/admin/update-meta.ts 20.00% 4 Missing :warning:
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14579 +/- ## =========================================== - Coverage 41.43% 41.39% -0.05% =========================================== Files 1543 1545 +2 Lines 197423 197761 +338 Branches 3603 3561 -42 =========================================== + Hits 81809 81867 +58 - Misses 115020 115330 +310 + Partials 594 564 -30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 3 weeks ago

マージするか

tai-cha commented 3 weeks ago

動作は見れてないけどコードを目で追った感じはYOSASOU

syuilo commented 3 weeks ago

🙏🏿

syuilo commented 3 weeks ago

(RBTがオフの状態でも)リアクション分裂現象が起こっている

syuilo commented 3 weeks ago

TASUKETE

fruitriin commented 3 weeks ago

(自分がポストしたとき?)ホスト名がnullではなく.になっていて、一致しなくて分裂しているらしい?

kakkokari-gtyih commented 3 weeks ago

旧バージョン

image

RBT導入後

image

なのでローカルの絵文字のホスト名のハンドリングをどちらかに寄せる必要がありそう

kakkokari-gtyih commented 3 weeks ago

image

これでいけたりする?(L71, 72)