misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

enhance: ユーザーコンテンツのインポート操作の実行可否をロールで制御できるように #14583

Closed kakkokari-gtyih closed 3 weeks ago

kakkokari-gtyih commented 3 weeks ago

What

かいてあるとおり

Why

Fix #14581

Additional info (optional)

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 21.62162% with 145 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (8d23122) to head (99db578). Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 100 Missing :warning:
packages/frontend/src/pages/admin/roles.vue 0.00% 40 Missing :warning:
...ages/frontend/src/pages/settings/import-export.vue 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14583 +/- ## =========================================== + Coverage 39.77% 41.48% +1.71% =========================================== Files 1539 1543 +4 Lines 191686 197603 +5917 Branches 2482 2607 +125 =========================================== + Hits 76241 81984 +5743 - Misses 114883 115057 +174 Partials 562 562 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

このPRによるapi.jsonの差分

差分はこちら ```diff --- base +++ head @@ -80932,6 +80932,21 @@ }, "avatarDecorationLimit": { "type": "integer" + }, + "canImportAntennas": { + "type": "boolean" + }, + "canImportBlocking": { + "type": "boolean" + }, + "canImportFollowing": { + "type": "boolean" + }, + "canImportMuting": { + "type": "boolean" + }, + "canImportUserLists": { + "type": "boolean" } }, "required": [ @@ -80960,7 +80975,12 @@ "userListLimit", "userEachUserListsLimit", "rateLimitFactor", - "avatarDecorationLimit" + "avatarDecorationLimit", + "canImportAntennas", + "canImportBlocking", + "canImportFollowing", + "canImportMuting", + "canImportUserLists" ] }, "ReversiGameLite": { ```

Get diff files from Workflow Page

kakkokari-gtyih commented 3 weeks ago

ちゃんと動いたのでready

syuilo commented 3 weeks ago

コンテンツごとに設定が分かれている必要はあるかしら

KisaragiEffective commented 3 weeks ago

目的を達成するためには別れてなくてもいいとは言えるが、別れていたほうが柔軟性を提供できて便利という説がある

syuilo commented 3 weeks ago

あまり別々に設定したいシチュエーションが思い浮かばない

KisaragiEffective commented 3 weeks ago

のでフォローとそれ以外にするのはありかもしれない

syuilo commented 3 weeks ago

ほむん

kakkokari-gtyih commented 3 weeks ago

分かれているぶんにはデメリットは無い気がする

syuilo commented 3 weeks ago

👍🏿

syuilo commented 3 weeks ago

分かれているぶんにはデメリットは無い気がする