misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

update deps #14594

Closed syuilo closed 3 weeks ago

syuilo commented 3 weeks ago
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 41.37%. Comparing base (00ccc22) to head (0c57ab8). Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/server/FileServerService.ts 0.00% 5 Missing :warning:
...ages/backend/src/server/web/ClientServerService.ts 20.00% 4 Missing :warning:
packages/backend/src/misc/fastify-hook-handlers.ts 0.00% 1 Missing :warning:
packages/backend/src/server/ServerService.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14594 +/- ## =========================================== + Coverage 39.75% 41.37% +1.61% =========================================== Files 1541 1545 +4 Lines 192170 197907 +5737 Branches 2545 3594 +1049 =========================================== + Hits 76402 81885 +5483 - Misses 115206 115426 +220 - Partials 562 596 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

このPRによるapi.jsonの差分

差分はこちら ```diff ```

Get diff files from Workflow Page

syuilo commented 3 weeks ago

bull-boardがfastify 5に対応してないな

syuilo commented 3 weeks ago

TypeError: Key "rules": Key "@typescript-eslint/func-call-spacing": Could not find "func-call-spacing" in plugin "@typescript-eslint". Did you mean "@/func-call-spacing"?

syuilo commented 3 weeks ago

Misskeyではfunc-call-spacingなるものは使っていない

kakkokari-gtyih commented 3 weeks ago

Misskeyではfunc-call-spacingなるものは使っていない

使っている https://github.com/misskey-dev/eslint-plugin-misskey-dev/blob/965f099ab0c583f67e15637305c596bdf9bf05ef/configs/typescript.js#L17

typescript-eslint v8でスタイル系のlintルールが削除されて別パッケージに移行したのでそれに対応する必要がある( https://github.com/misskey-dev/eslint-plugin-misskey-dev/issues/6

github-actions[bot] commented 3 weeks ago

api.jsonの差分作成中にエラーが発生しました。詳細はWorkflowのログを確認してください。

syuilo commented 3 weeks ago

eslintだけ戻すか

syuilo commented 3 weeks ago

マージするか

syuilo commented 3 weeks ago

🙏🏻