feat: サーバー初期設定時に初期パスワードを要求できるように

misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀

https://misskey-hub.net/

GNU Affero General Public License v3.0

9.95k stars 1.35k forks source link

feat: サーバー初期設定時に初期パスワードを要求できるように #14626

Closed kakkokari-gtyih closed 1 week ago

kakkokari-gtyih commented 2 weeks ago

What

初期設定開始時に初期パスワードを要求できるように

Why

Additional info (optional)

Checklist

[x] Read the contribution guide
[ ] Test working in a local environment
[ ] (If needed) Add story of storybook
[x] (If needed) Update CHANGELOG.md
[ ] (If possible) Add tests

github-actions[bot] commented 2 weeks ago

このPRによるapi.jsonの差分

差分はこちら

```diff --- base +++ head @@ -1971,6 +1971,12 @@ "password": { "type": "string", "minLength": 1 + }, + "initialPassword": { + "type": [ + "string", + "null" + ] } }, "required": [ @@ -2009,6 +2015,24 @@ "$ref": "#/components/schemas/Error" }, "examples": { + "ACCESS_DENIED": { + "value": { + "error": { + "message": "Access denied.", + "code": "ACCESS_DENIED", + "id": "1fb7cb09-d46a-4fff-b8df-057708cce513" + } + } + }, + "INCORRECT_INITIAL_PASSWORD": { + "value": { + "error": { + "message": "Initial password is incorrect.", + "code": "INCORRECT_INITIAL_PASSWORD", + "id": "97147c55-1ae1-4f6f-91d6-e1c3e0e76d62" + } + } + }, "INVALID_PARAM": { "value": { "error": { ``` [Get diff files from Workflow Page](https://github.com/misskey-dev/misskey/actions/runs/11159215821)

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 33.33333% with 42 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (75ea964) to head (aab74bf). Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/frontend/src/pages/welcome.setup.vue	0.00%	22 Missing :warning:
.../src/server/api/endpoints/admin/accounts/create.ts	45.94%	20 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #14626 +/- ## =========================================== + Coverage 39.69% 41.39% +1.70% =========================================== Files 1545 1549 +4 Lines 193848 199643 +5795 Branches 3608 2631 -977 =========================================== + Hits 76952 82650 +5698 - Misses 116299 116428 +129 + Partials 597 565 -32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 2 weeks ago

動いてそうだけど手元で検証できないのでやっていただきたい気持ち

kakkokari-gtyih commented 2 weeks ago

試しにcypressでパスワードの値を変えてみたら（ https://github.com/misskey-dev/misskey/pull/14626/commits/66b2b48f66830d2450d8cda03955c143feba76c7 ）変な止まり方して成功扱いになった

https://github.com/misskey-dev/misskey/actions/runs/11024875489/job/30618786666

zyoshoka commented 2 weeks ago

admin/accounts/create エンドポイント自体は初期設定以外でも管理者がアカウントを作る際にも使われますが、config に設定したままだと毎回 initialPassword が要求されてしまうのは微妙な気がします

kakkokari-gtyih commented 2 weeks ago

なおったかも