misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(misskey-js): correct `noteUpdated` event type #14632

Closed zyoshoka closed 2 weeks ago

zyoshoka commented 2 weeks ago

What

misskey-js の型定義において noteUpdated イベントの型が不正確なのを修正します。

Why

肝心のノートの id も送られるはずなので https://github.com/misskey-dev/misskey/blob/0f8b15f0fec1a474b8f5a0c0c4b7be5ccd42b493/packages/backend/src/server/api/stream/Connection.ts#L211-L217

Additional info (optional)

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.32%. Comparing base (0f8b15f) to head (6c78ee4). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14632 +/- ## =========================================== + Coverage 39.58% 40.32% +0.73% =========================================== Files 1542 1546 +4 Lines 192800 198537 +5737 Branches 2475 3289 +814 =========================================== + Hits 76319 80058 +3739 - Misses 115916 117877 +1961 - Partials 565 602 +37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syuilo commented 2 weeks ago

🙏🏿