misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(backend): embedの動作に必要な値を復活させる #14633

Closed kakkokari-gtyih closed 2 weeks ago

kakkokari-gtyih commented 2 weeks ago

What

Why

frontend-shared/js/config.ts にはHTML要素を参照する実装があるが、embed htmlで一部要素が提供されておらず、表示がおかしくなることがあるため

Additional info (optional)

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.58%. Comparing base (5c94b4c) to head (6a3f85e). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14633 +/- ## =========================================== - Coverage 39.61% 39.58% -0.04% =========================================== Files 1542 1542 Lines 192808 192800 -8 Branches 3538 2524 -1014 =========================================== - Hits 76381 76319 -62 - Misses 115831 115916 +85 + Partials 596 565 -31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

syuilo commented 2 weeks ago

🙏🏻