misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix(backend): 連合限定先が間違って連合しない先に代入されているのを修正 #14662

Closed KisaragiEffective closed 1 week ago

KisaragiEffective commented 1 week ago

What

close #14661 close #14671

Why

同上

Additional info (optional)

テスト追加したいのでマージは待って

Checklist

github-actions[bot] commented 1 week ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

KisaragiEffective commented 1 week ago

Thank you for sending us a great Pull Request! 👍 Please regenerate misskey-js type definitions! 🙏

example:

pnpm run build-misskey-js-with-types

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.77%. Comparing base (1e9813e) to head (dec4d77). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/server/api/endpoints/admin/update-meta.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14662 +/- ## =========================================== + Coverage 38.64% 39.77% +1.12% =========================================== Files 1545 1545 Lines 193848 193848 Branches 2271 2557 +286 =========================================== + Hits 74921 77107 +2186 + Misses 118362 116178 -2184 + Partials 565 563 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kakkokari-gtyih commented 1 week ago

Thank you for sending us a great Pull Request! 👍 Please regenerate misskey-js type definitions! 🙏 example:

pnpm run build-misskey-js-with-types

developのmisskey-jsの型が不足してたみたい(今update branchしたらなおるはず)

syuilo commented 1 week ago

マージするか

KisaragiEffective commented 1 week ago

まぁテストは後でも良い

syuilo commented 1 week ago

🙏🏻