misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

Make post form attachments accessible #14666

Closed K4rakara closed 1 week ago

K4rakara commented 1 week ago

What

Adds a role="button", tabindex, and v-on:keydown to MkPostFormAttaches.

Why

Without this, users who are navigating the UI with a keyboard cannot add alt text to media, mark media as sensitive, or even remove media from the post they are composing.

Checklist

*I've tested the parts I've changed in the browser, and they work, but for some reason I can't get pnpm run test to pass due to something with _misskey_content. I assume this is a misconfiguration of the test environment on my part (I just copied the default.yml to test.yml), but I'm not sure how.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 19.53%. Comparing base (e9519b0) to head (76d95f2). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14666 +/- ## ============================================ - Coverage 41.40% 19.53% -21.88% ============================================ Files 1549 716 -833 Lines 199468 101501 -97967 Branches 3623 987 -2636 ============================================ - Hits 82595 19826 -62769 + Misses 116276 81129 -35147 + Partials 597 546 -51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

K4rakara commented 1 week ago

Forgot to add- this is based on this Sharkey MR: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/638

syuilo commented 1 week ago

🙏🏿