misskey-dev / misskey

🌎 A completely free and open interplanetary microblogging platform 🚀
https://misskey-hub.net/
GNU Affero General Public License v3.0
9.95k stars 1.35k forks source link

fix: signin の資格情報が足りないだけの場合はエラーにせず200を返すように #14700

Closed kakkokari-gtyih closed 1 week ago

kakkokari-gtyih commented 1 week ago

What

Why

Fix #14699

Additional info (optional)

Checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 1.89873% with 155 lines in your changes missing coverage. Please review.

Project coverage is 41.28%. Comparing base (fa06c59) to head (cb426bc). Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkSignin.vue 0.00% 123 Missing :warning:
...ackages/backend/src/server/api/SigninApiService.ts 10.00% 18 Missing :warning:
...es/frontend/src/components/MkSignupDialog.form.vue 0.00% 8 Missing :warning:
packages/backend/src/server/api/SigninService.ts 25.00% 3 Missing :warning:
...ackages/frontend/src/components/MkSignupDialog.vue 0.00% 2 Missing :warning:
...ackages/backend/src/server/api/ApiServerService.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #14700 +/- ## =========================================== + Coverage 39.67% 41.28% +1.60% =========================================== Files 1548 1552 +4 Lines 194496 200224 +5728 Branches 2566 3579 +1013 =========================================== + Hits 77174 82668 +5494 - Misses 116756 116955 +199 - Partials 566 601 +35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

このPRによるapi.jsonの差分 差分はありません。 Get diff files from Workflow Page

anatawa12 commented 1 week ago

うーん資格情報が足りない状態でのレスポンスに200は強い違和感を持ちますね

403が違うってのは多分そうなのですが、401は不適当ですし400あたりがよいと私は感じます

kakkokari-gtyih commented 1 week ago

うーん資格情報が足りない状態でのレスポンスに200は強い違和感を持ちますね

403が違うってのは多分そうなのですが、401は不適当ですし400あたりがよいと私は感じます

仕様通り想定して飛んできているリクエストに対してエラーを返すのはおかしい

https://github.com/misskey-dev/misskey/issues/14699

kakkokari-gtyih commented 1 week ago

tabun done

syuilo commented 1 week ago

ファイル名とかクラス名は変えなくても良い気がするわね

kakkokari-gtyih commented 1 week ago

ファイル名とかクラス名は変えなくても良い気がするわね

もどした

kakkokari-gtyih commented 1 week ago

👀

syuilo commented 1 week ago

🙏🏿